Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim pyproject.toml and MANIFEST.in #13137

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Trim pyproject.toml and MANIFEST.in #13137

merged 1 commit into from
Dec 31, 2024

Conversation

ichard26
Copy link
Member

This mostly removes legacy references to files that do not exist anymore. In addition, the smarter exclude_also coverage option is used instead of exclude_lines so we don't need to readd the default exclude.

This mostly removes legacy references to files that do not exist
anymore. In addition, the smarter exclude_also coverage option is
used instead of exclude_lines.
@ichard26 ichard26 added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Dec 30, 2024
@ichard26
Copy link
Member Author

I checked that this has no unintentional impact on the pip sdist and wheel using pkgdiff (a very cool project). There are no changes in the wheel and only pyproject.toml and MANIFEST.in had changes in the sdist as expected :)

I also tested the new coverage configuration. Our current coverage nox session is actually broken, but after fixing that, exclude_also is working as expected.

@ichard26 ichard26 merged commit bc553db into pypa:main Dec 31, 2024
11 checks passed
@ichard26 ichard26 deleted the cleanup branch December 31, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants