Merge pull request #1669 from pypeit/datacube_core

Datacube core
pypeit · Oct 14, 2023 · 0c03daf · 0c03daf
2 parents b23ec14 + 3ad7d3c
commit 0c03daf
Show file tree

Hide file tree

Showing 27 changed files with 2,529 additions and 1,747 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -58,7 +58,7 @@ RELEASE FILE IN doc/releases
       files that have frametype None (this prevent ``run_pypeit`` to crash)
     - Added a function ``check_spectrograph()`` (currently only defined for LRIS),
       that checks (during ``pypeit_setup``) if the selected spectrograph is the
-      corrected one for the data used. 
+      corrected one for the data used.
 
 
 1.13.0 (2 June 2023)

diff --git a/doc/coadd3d.rst b/doc/coadd3d.rst
@@ -155,13 +155,13 @@ Sky Subtraction
 
 The default behaviour of PypeIt is to subtract the model sky that is
 derived from the science frame during the reduction. If you would like
-to turn off sky subtraction, set the following keyword argument:
+to turn off sky subtraction, set the following keyword argument (all lowercase):
 
 .. code-block:: ini
 
     [reduce]
         [[cube]]
-            skysub_frame = None
+            skysub_frame = none
 
 If you would like to use a dedicated sky frame for sky subtraction
 that is separate from the science frame, then you need to provide
@@ -330,7 +330,7 @@ plot a wavelength slice of the cube:
 
     from matplotlib import pyplot as plt
     from astropy.visualization import ZScaleInterval, ImageNormalize
-    from pypeit.core.datacube import DataCube
+    from pypeit.coadd3d import DataCube
 
     filename = "datacube.fits"
     cube = DataCube.from_file(filename)

diff --git a/doc/include/spectrographs_table.rst b/doc/include/spectrographs_table.rst
@@ -18,7 +18,7 @@ jwst_nirspec              :class:`~pypeit.spectrographs.jwst_nirspec.JWSTNIRSpec
 keck_deimos               :class:`~pypeit.spectrographs.keck_deimos.KeckDEIMOSSpectrograph`             KECK       DEIMOS        `Link <https://www2.keck.hawaii.edu/inst/deimos/>`__                                                                             MultiSlit  True       True       Supported gratings: 600ZD, 830G, 900ZD, 1200B, 1200G; see :doc:`deimos`                        
 keck_esi                  :class:`~pypeit.spectrographs.keck_esi.KeckESISpectrograph`                   KECK       ESI                                                                                                                                            Echelle    True       False                                                                                                     
 keck_hires                :class:`~pypeit.spectrographs.keck_hires.KECKHIRESSpectrograph`               KECK       HIRES         `Link <https://www2.keck.hawaii.edu/inst/hires/>`__                                                                              Echelle    False      False                                                                                                     
-keck_kcrm                 :class:`~pypeit.spectrographs.keck_kcwi.KeckKCRMSpectrograph`                 KECK       KCRM          `Link <https://www2.keck.hawaii.edu/inst/kcwi/>`__                                                                               IFU        True       False      Supported setups: RM1, RM2, RH3; see :doc:`keck_kcwi`                                          
+keck_kcrm                 :class:`~pypeit.spectrographs.keck_kcwi.KeckKCRMSpectrograph`                 KECK       KCRM          `Link <https://www2.keck.hawaii.edu/inst/kcwi/>`__                                                                               IFU        True       False      Supported setups: RL, RM1, RM2, RH3; see :doc:`keck_kcwi`
 keck_kcwi                 :class:`~pypeit.spectrographs.keck_kcwi.KeckKCWISpectrograph`                 KECK       KCWI          `Link <https://www2.keck.hawaii.edu/inst/kcwi/>`__                                                                               IFU        True       False      Supported setups: BL, BM, BH2; see :doc:`keck_kcwi`                                            
 keck_lris_blue            :class:`~pypeit.spectrographs.keck_lris.KeckLRISBSpectrograph`                KECK       LRISb         `Link <https://www2.keck.hawaii.edu/inst/lris/>`__                                                                               MultiSlit  True       False      Blue camera; Current FITS file format; used from May 2009, see :doc:`lris`                     
 keck_lris_blue_orig       :class:`~pypeit.spectrographs.keck_lris.KeckLRISBOrigSpectrograph`            KECK       LRISb         `Link <https://www2.keck.hawaii.edu/inst/lris/>`__                                                                               MultiSlit  True       False      Blue camera; Original FITS file format; used until April 2009; see :doc:`lris`                 

diff --git a/doc/pypeit_par.rst b/doc/pypeit_par.rst
diff --git a/doc/releases/1.14.1dev.rst b/doc/releases/1.14.1dev.rst
@@ -12,10 +12,13 @@ Functionality/Performance Improvements and Additions
 
 - Started the development of instrument-specific scattered light removal. In this
   release, we only model KCWI/KCRM scattered light.
+- Added support for Keck/KCRM RL data reduction.
 
 Instrument-specific Updates
 ---------------------------
 
+- Keck/KCWI and Keck/KCRM: Turned on polynomial correction for sky subtraction.
+
 Script Changes
 --------------
 
@@ -25,14 +28,21 @@ Script Changes
 Datamodel Changes
 -----------------
 
+- A wavelength array is now stored for DataCube()
+
 Under-the-hood Improvements
 ---------------------------
 
+- The CoAdd3D code has been refactored into a series of core modules and PypeIt-specific routines.
+
 Bug Fixes
 ---------
 
 - Fixed bug associated with finding more than one file with the same name (but
   presumably different extensions).
+- Fixed differential atmospheric refraction (DAR) correction bug. This bug affected
+  datacubes combined using CoAdd3D(). Previously, the DAR was being computed, applied,
+  and then later overwritten. The new routine is faster and more accurate.
 - Fixed a bug associated with an incorrect date for the transition to the Mark4
   detector for Keck/LRIS RED.