Skip to content

Commit

Permalink
Merge pull request #1700 from pypeit/fors2_mos
Browse files Browse the repository at this point in the history
Add support for VLT/FORS2 MOS mode
  • Loading branch information
rcooke-ast authored Oct 17, 2023
2 parents e999155 + faf99d7 commit 2b3a8d1
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 11 deletions.
3 changes: 2 additions & 1 deletion doc/releases/1.14.1dev.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@ Functionality/Performance Improvements and Additions
release, we only model KCWI/KCRM scattered light.
- Turned on usage of the use_2dmodel_mask parameter for echelle spectrographs
- Added support for Keck/KCRM RL data reduction.
- Allow one to turn off reinit of reduce_bpm in global_skysub and made this
- Allow one to turn off reinit of reduce_bpm in global_skysub and made this
the default for the final pass

Instrument-specific Updates
---------------------------

- Keck/KCWI and Keck/KCRM: Turned on polynomial correction for sky subtraction.
- We now support the reduction of VLT/FORS2 data taken in MOS mode.

Script Changes
--------------
Expand Down
28 changes: 18 additions & 10 deletions pypeit/spectrographs/vlt_fors.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,22 @@ def compound_meta(self, headarr, meta_key):
binning = parse.binning2string(binspec, binspatial)
return binning
elif meta_key == 'decker':
try: # Science
decker = headarr[0]['HIERARCH ESO INS SLIT NAME']
except KeyError: # Standard!
try:
decker = headarr[0]['HIERARCH ESO SEQ SPEC TARG']
except KeyError:
return None
return decker
mode = headarr[0]['HIERARCH ESO INS MODE']
if mode == 'LSS':
try: # Science
return headarr[0]['HIERARCH ESO INS SLIT NAME']
except KeyError: # Standard!
try:
return headarr[0]['HIERARCH ESO SEQ SPEC TARG']
except KeyError:
return None
elif mode == 'MOS':
return headarr[0]['HIERARCH ESO INS MOS CHECKSUM']
elif mode == 'IMG':
# This is for the bias frames
return None
else:
msgs.error(f"PypeIt does not currently support VLT/FORS2 '{mode}' data reduction.")
else:
msgs.error("Not ready for this compound meta")

Expand Down Expand Up @@ -207,7 +215,7 @@ class VLTFORS2Spectrograph(VLTFORSSpectrograph):
camera = 'FORS2'
header_name = 'FORS2'
supported = True
comment = '300I, 300V gratings'
comment = '300I, 300V gratings. Supports LSS and MOS mode only.'

def get_detector_par(self, det, hdu=None):
"""
Expand Down Expand Up @@ -354,7 +362,7 @@ def config_independent_frames(self):
keywords that can be used to assign the frames to a configuration
group.
"""
return {'bias': 'detector', 'dark': 'detector'}
return {'bias': 'detector', 'dark': 'detector', 'standard':['detector', 'dispangle', 'dispname']}

def configuration_keys(self):
"""
Expand Down

0 comments on commit 2b3a8d1

Please sign in to comment.