Wrapping up, some last documentation updates and bug fixes #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `doc/scripts` directory, replace all possible `os` calls with their equivalent `pathlib` call. Also, changed string formatting to f-strings where applicable. In `pypeit.data.utils`, greatly simplified the Path class in addition to shifting from `pkg_resources` to `importlib`. modified: doc/conf.py modified: doc/scripts/build_afterburn_datamodels_rst.py modified: doc/scripts/build_bitmask_rst.py modified: doc/scripts/build_calib_images_rst.py modified: doc/scripts/build_datacontainer_datamodels.py modified: doc/scripts/build_dependency_rst.py modified: doc/scripts/build_detector_table.py modified: doc/scripts/build_imgproc_defaults.py modified: doc/scripts/build_par_rst.py modified: doc/scripts/build_specobj_rst.py modified: doc/scripts/build_spectbl_rst.py modified: doc/scripts/make_example_files.py modified: doc/scripts/unique_configuration_keys.py modified: doc/scripts/write_script_help.py modified: pypeit/data/utils.py
Going all-in on `pathlib`
modified: doc/scripts/build_bitmask_rst.py modified: doc/scripts/build_dependency_rst.py modified: doc/scripts/build_detector_table.py modified: doc/scripts/build_imgproc_defaults.py modified: doc/scripts/build_par_rst.py modified: doc/scripts/build_specobj_rst.py modified: doc/scripts/build_spectbl_rst.py modified: doc/scripts/make_example_files.py modified: doc/scripts/write_script_help.py
Tests pass ``` Test Summary -------------------------------------------------------- --- PYTEST PYPEIT UNIT TESTS PASSED 239 passed, 70 warnings in 549.16s (0:09:09) --- --- PYTEST UNIT TESTS PASSED 133 passed, 171 warnings in 1006.59s (0:16:46) --- --- PYTEST VET TESTS PASSED 58 passed, 68 warnings in 1070.66s (0:17:50) --- --- PYPEIT DEVELOPMENT SUITE PASSED 231/231 TESTS --- Testing Started at 2023-10-02T21:32:49.404150 Testing Completed at 2023-10-03T14:51:06.930614 Total Time: 17:18:17.526464 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.