Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix: VLT/FORS2 #1707

Merged
merged 4 commits into from
Oct 21, 2023
Merged

HotFix: VLT/FORS2 #1707

merged 4 commits into from
Oct 21, 2023

Conversation

rcooke-ast
Copy link
Collaborator

This fixes the reduction for both LSS and MOS, after a mistake in PR #1700. There is also a companion dev-suite PR.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #1707 (6770987) into develop (2b3a8d1) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff            @@
##           develop    #1707   +/-   ##
========================================
  Coverage    41.08%   41.08%           
========================================
  Files          190      190           
  Lines        43631    43629    -2     
========================================
  Hits         17927    17927           
+ Misses       25704    25702    -2     
Files Coverage Δ
pypeit/spectrographs/vlt_fors.py 20.85% <0.00%> (+0.25%) ⬆️

Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a minor comments about what might be a lingering print statement.

pypeit/spectrographs/vlt_fors.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving

@rcooke-ast
Copy link
Collaborator Author

Dev suite and tests pass...
image

@rcooke-ast rcooke-ast merged commit a600f27 into develop Oct 21, 2023
23 checks passed
@rcooke-ast rcooke-ast deleted the hotfix_fors2 branch October 21, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants