Adds R4K support for MDM OSMOS #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #1710 +/- ##
===========================================
- Coverage 41.06% 41.04% -0.03%
===========================================
Files 190 190
Lines 43661 43714 +53
===========================================
+ Hits 17930 17941 +11
- Misses 25731 25773 +42
|
rcooke-ast
approved these changes
Oct 21, 2023
|
Tests pass for both MDM detectors |
kbwestfall
approved these changes
Oct 23, 2023
| the data one receives to have been | ||
| windowed. You may therefore need to | ||
| window the rest. There is a Notebook | ||
| in the DevSuite that shows an example of |
| Return metadata for the selected detector. | ||
|
|
||
| THIS IS FOR WINDOWED SCIENCE FRAMES | ||
| AND WE ARE HACKING THE CALIBS |
There was a problem hiding this comment.
We should consider providing a script that does this. I realize this is pretty specific because it's only needed for this instrument, but I imagine users would be happier calling something like pypeit_prep_data mdm_osmos_4k *.fits then having to dig up the notebook. That script can apply to more instruments as needed (e.g., we could use it to help people add the slit info from tilsotua for LRIS).
|
Could this PR have produced an error on the dev suite? 
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
This detector is obsolete so I doubt there will be
much usage. But here it is anyways!
One catch -- the "raw" frames users often receive
are not raw.