Hotfix: use mask in specutils loader #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbowers7
requested changes
Oct 30, 2023
Comment on lines
+200
to
+201
| _wave, _flux, _ivar = _enforce_monotonic_wavelengths(_wave[_gpm], _flux[_gpm], _ivar[_gpm], | ||
| strict=strict) |
There was a problem hiding this comment.
What happens if there are no good pixels (i.e., all are zero for some reason)? Will _enforce_monotonic_wavelengths() as written choke on empty input arrays? Maybe add an edge-case check to bypass the enforcement in this case?
There was a problem hiding this comment.
Good catch! What do you think of my fix:
if not np.any(_gpm):
msgs.warn(f'Spectrum {sobj.NAME} is fully masked and will be ignored!')
continue
tbowers7
approved these changes
Oct 30, 2023
Comment on lines
+200
to
+201
| _wave, _flux, _ivar = _enforce_monotonic_wavelengths(_wave[_gpm], _flux[_gpm], _ivar[_gpm], | ||
| strict=strict) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. The new check on a monotonically increasing wavelength vector caused problems for some spectrographs that have wavelengths set to 0. This is avoided by using the mask.