Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.8.1 #3054

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Bump version to 1.8.1 #3054

merged 4 commits into from
Mar 24, 2022

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Mar 22, 2022

In preparation for 1.8.1 release:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fritzo fritzo added this to the 1.8.1 release milestone Mar 22, 2022
@fritzo
Copy link
Member Author

fritzo commented Mar 22, 2022

Looks like we're seeing #3046 again with funsor==0.4.3. @ordabayevy to try to get tests to pass I've reverted #3048 (which had simply removed xfails)

@fritzo fritzo added the WIP label Mar 22, 2022
@fritzo
Copy link
Member Author

fritzo commented Mar 22, 2022

Gosh looking at the funsor changelog, it looks like the only relevant change was @eb8680's and my #584 which modified partial_sum_product() 🤔

@fritzo
Copy link
Member Author

fritzo commented Mar 22, 2022

Indeed git bisect shows the offending commit is @eb8680's and my pyro-ppl/funsor#584

@eb8680
Copy link
Member

eb8680 commented Mar 22, 2022

It looks like re-running the tests made them pass? There were at least a couple tests off by a factor of 2 rather than numerical error, which is odd. I'll look into the failures this evening. I don't think it's worth blocking a Pyro release on contrib.funsor bugs though - I'd be OK with either releasing as-is with some tests marked xfail or reverting the change in Funsor. I'll look into the failures tonight.

@fritzo
Copy link
Member Author

fritzo commented Mar 22, 2022

@eb8680 the tests passed because I xfailed them 😊 LMK if you want to pair debug on our funsor PR. I'm ok either reverting that PR or releasing pyro with some contrib.funsor bugs, but I'd prefer to do a quick bugfix release of funsor 0.4.4 if we can find & fix the error. It took so long to get that PR merged...

@fritzo fritzo requested a review from fehiepsi March 23, 2022 15:29
@fritzo
Copy link
Member Author

fritzo commented Mar 23, 2022

@fehiepsi-- @eb8680 are ok merging this with the xfailed tests in contrib.funsor and we can look into fixing those tests later. I think the PyTorch update is higher priority.

@martinjankowiak martinjankowiak merged commit d58b00b into dev Mar 24, 2022
@fritzo
Copy link
Member Author

fritzo commented Mar 24, 2022

Thanks @martinjankowiak !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants