-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 1.8.1 #3054
Bump version to 1.8.1 #3054
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This reverts commit 0c3be04.
Looks like we're seeing #3046 again with |
Gosh looking at the funsor changelog, it looks like the only relevant change was @eb8680's and my #584 which modified |
Indeed git bisect shows the offending commit is @eb8680's and my pyro-ppl/funsor#584 |
It looks like re-running the tests made them pass? There were at least a couple tests off by a factor of 2 rather than numerical error, which is odd. I'll look into the failures this evening. I don't think it's worth blocking a Pyro release on |
@eb8680 the tests passed because I xfailed them 😊 LMK if you want to pair debug on our funsor PR. I'm ok either reverting that PR or releasing pyro with some contrib.funsor bugs, but I'd prefer to do a quick bugfix release of funsor 0.4.4 if we can find & fix the error. It took so long to get that PR merged... |
@fehiepsi-- @eb8680 are ok merging this with the xfailed tests in contrib.funsor and we can look into fixing those tests later. I think the PyTorch update is higher priority. |
Thanks @martinjankowiak ! |
In preparation for 1.8.1 release: