Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add htslib/hts_probe_cc.sh to sdist #1247

Closed
wants to merge 1 commit into from

Conversation

nsoranzo
Copy link
Contributor

Otherwise the before-build command make -C {project}/htslib distclean from pyproject.toml fail with:

      + sh -c 'make -C /project/htslib distclean'
  Makefile:142: htscodecs.mk: No such file or directory
  make: Entering directory `/project/htslib'
  echo '# Default htscodecs.mk generated by Makefile' > htscodecs.mk
  echo 'include $(HTSPREFIX)htscodecs_bundled.mk' >> htscodecs.mk
  ./hts_probe_cc.sh 'gcc' '-g -Wall -O2 -fvisibility=hidden ' '-fvisibility=hidden' >> htscodecs.mk
  /bin/sh: ./hts_probe_cc.sh: No such file or directory
  make: *** [htscodecs.mk] Error 127
  make: Leaving directory `/project/htslib'

Otherwise the `before-build` command `make -C {project}/htslib distclean` from `pyproject.toml` fail with:

```
      + sh -c 'make -C /project/htslib distclean'
  Makefile:142: htscodecs.mk: No such file or directory
  make: Entering directory `/project/htslib'
  echo '# Default htscodecs.mk generated by Makefile' > htscodecs.mk
  echo 'include $(HTSPREFIX)htscodecs_bundled.mk' >> htscodecs.mk
  ./hts_probe_cc.sh 'gcc' '-g -Wall -O2 -fvisibility=hidden ' '-fvisibility=hidden' >> htscodecs.mk
  /bin/sh: ./hts_probe_cc.sh: No such file or directory
  make: *** [htscodecs.mk] Error 127
  make: Leaving directory `/project/htslib'
```
@nsoranzo nsoranzo changed the title Add htslib/hts_probe_cc.sh to sdist Add htslib/hts_probe_cc.sh to sdist Nov 30, 2023
@nsoranzo
Copy link
Contributor Author

This is not needed any more after commit 8ab5287, closing.

@nsoranzo nsoranzo closed this Apr 24, 2024
@nsoranzo nsoranzo deleted the patch-1 branch April 24, 2024 11:24
@jmarshall
Copy link
Member

jmarshall commented Apr 24, 2024

Yes, we don’t use hts_probe_cc.sh during building so we don’t really want to use it just for cleaning, so as you noticed I wanted to fix this in a different way. Thanks for reporting the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants