Adds config for Travis CI #60
Conversation
ashwamegh
commented
Jul 16, 2017
•
ashwamegh
commented
- Adds a config file for Travis CI for automated testing
- For Deployment : Details needed mentioned in https://docs.travis-ci.com/user/deployment
js/main.js
Outdated
| @@ -48,6 +48,32 @@ jQuery(document).on('ready', function() { | |||
| scrollTop: jQuery("#tg-main").offset().top + offset | |||
| }, 2000); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Why is this snippet in the config for Travis CI PR?
There was a problem hiding this comment.
@CuriousLearner I earlier submitted a PR #50, whose code remained in this branch when I checkout naming the new branch travis-ci, that's why the code is appearing here.
- Once the PR#50 is merged, it will not show these changes.
- I will remember to keep the
masterbranch clean onwards
There was a problem hiding this comment.
So, please get this change reverted in this PR.
|
@CuriousLearner Done reverting changes from my fork of |
|
Will wait for @theskumar for review on this. This would be on hold till he comes back! |
|
Fix #60 In order to prevent multiple PRs for same issues ;) |
|
@theskumar Can you please review this? |
| install: | ||
| - pip install -r requirements.txt | ||
| script: | ||
| - python test.py |
There was a problem hiding this comment.
Because it will build for a inifinite number of times watching file changes and will not pass for now.
Have a look on its output:
Worker information
hostname: i-0f6ba05-precise-production-2-worker-org-docker.travisci.net:feb3e67c-f78e-4ecd-94d9-0ba3bb8edbee
version: v2.5.0 https://github.com/travis-ci/worker/tree/da3a43228dffc0fcca5a46569ca786b22991979f
instance: 48066c3:travis:python
startup: 765.298551ms
Skipping a long starting log......................
Running setup.py install for watchdog
Installing watchmedo script to /home/travis/virtualenv/python2.7.9/bin
Compiling /tmp/pip-build-xZvIXJ/jinja2/jinja2/asyncfilters.py
Compiling /tmp/pip-build-xZvIXJ/jinja2/jinja2/asyncsupport.py
Running setup.py install for easywatch
Running setup.py install for docopt
Running setup.py install for staticjinja
Installing staticjinja script to /home/travis/virtualenv/python2.7.9/bin
Successfully installed MarkupSafe-1.0 PyYAML-3.12 argh-0.26.2 docopt-0.6.2 easywatch-0.0.3 jinja2-2.9.6 pathtools-0.1.2 staticjinja-0.3.3 watchdog-0.8.3
$ python build.py
Rendering coc.html...
Rendering faqs.html...
Rendering gallery.html...
Rendering index.html...
Rendering sponsors.html...
Rendering sponsorship.html...
Rendering volunteer.html...
Watching '/home/travis/build/pythonindia/inpycon2017/templates' for changes...
Press Ctrl+C to stop.There was a problem hiding this comment.
I see.
But then with the current setup, I am not sure of the advantages of having a CI.
One solution would be to implement a --watch/-w flag in build.py, that will only watch the files when its specified
|
As said by @SanketDG the build.py would need to updated to support both the reload mode and without it, so it's able to just build and generate the files in non-interactive mode. Once that is done, there are multiple ways to test the website (automated / manually), let's ignore that fact for now, and I won't go too deep into it. If somebody able to pull-off some test setup say using selenium/phantomjs, very wonder full. For now the workflow should be:
Summarising, the immediate requirement is that if a code is pushed to |
