Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Add back `must-revalidate`

Co-authored-by: Andrey Talman <[email protected]>
  • Loading branch information
edmorley and atalman authored Jan 20, 2025
1 parent 37a778d commit 222a002
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions s3_management/manage.py
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ def upload_libtorch_html(self) -> None:
key=f"{subdir}/{self.html_name}"
).put(
ACL='public-read',
CacheControl='max-age=600, public',
CacheControl='max-age=600, public, must-revalidate',
ContentType='text/html',
Body=index_html
)
Expand All @@ -440,7 +440,7 @@ def upload_pep503_htmls(self) -> None:
key=f"{subdir}/index.html"
).put(
ACL='public-read',
CacheControl='max-age=600, public',
CacheControl='max-age=600, public, must-revalidate',
ContentType='text/html',
Body=index_html
)
Expand All @@ -453,7 +453,7 @@ def upload_pep503_htmls(self) -> None:
key=f"{subdir}/{compat_pkg_name}/index.html"
).put(
ACL='public-read',
CacheControl='max-age=600, public',
CacheControl='max-age=600, public, must-revalidate',
ContentType='text/html',
Body=index_html
)
Expand Down

0 comments on commit 222a002

Please sign in to comment.