Skip to content

Commit

Permalink
upgrade download/upload artifact to v4 (#6151)
Browse files Browse the repository at this point in the history
  • Loading branch information
vmoens authored Jan 9, 2025
1 parent d28c931 commit 2ec4ddc
Show file tree
Hide file tree
Showing 11 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/_binary_conda_upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
upload-to-base-bucket: ${{ matrix.upload_to_base_bucket }}

- name: Download the artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ env.ARTIFACT_NAME }}
path: ${{ inputs.repository }}/distr
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_binary_upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:

- name: Download the artifact
if: ${{ env.DO_UPLOAD == 'true' }}
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ env.ARTIFACT_NAME }}
path: ${{ inputs.repository }}/dist/
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_upload_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
ref: ${{ inputs.docs-branch }}
persist-credentials: true
- name: Download artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.docs-name }}
path: docs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_wheels_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ jobs:
- name: Upload wheel to GitHub
if: ${{ env.IS_MANYLINUX2_28 == 'true' }}
continue-on-error: true
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.ARTIFACT_NAME }}
path: ${{ inputs.repository }}/dist/
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_wheels_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ jobs:
# NB: Only upload to GitHub after passing smoke tests
- name: Upload wheel to GitHub
continue-on-error: true
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.ARTIFACT_NAME }}
path: ${{ inputs.repository }}/dist/
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_wheels_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ jobs:
# NB: Only upload to GitHub after passing smoke tests
- name: Upload wheel to GitHub
continue-on-error: true
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.ARTIFACT_NAME }}
path: ${{ inputs.repository }}/dist/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/linux_job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ jobs:
if: ${{ steps.check_container_runner.outputs.IN_CONTAINER_RUNNER == 'true' }}

- name: Download artifacts (if any)
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
if: ${{ inputs.download-artifact != '' }}
with:
name: ${{ inputs.download-artifact }}
Expand Down Expand Up @@ -323,7 +323,7 @@ jobs:
# NB: Keep this for compatibility with existing jobs and also keep in mind that only
# our AWS runners have access to S3
- name: Upload artifacts to GitHub (if any)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ always() && inputs.upload-artifact != '' && !inputs.upload-artifact-to-s3 }}
with:
name: ${{ inputs.upload-artifact }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/linux_job_v2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ jobs:
if: ${{ steps.check_container_runner.outputs.IN_CONTAINER_RUNNER == 'true' }}

- name: Download artifacts (if any)
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
if: ${{ inputs.download-artifact != '' }}
with:
name: ${{ inputs.download-artifact }}
Expand Down Expand Up @@ -314,7 +314,7 @@ jobs:
# NB: Keep this for compatibility with existing jobs and also keep in mind that only
# our AWS runners have access to S3
- name: Upload artifacts to GitHub (if any)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ always() && inputs.upload-artifact != '' && !inputs.upload-artifact-to-s3 }}
with:
name: ${{ inputs.upload-artifact }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/macos_job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ jobs:
echo "RUNNER_TEST_RESULTS_DIR=${RUNNER_TEST_RESULTS_DIR}" >> "${GITHUB_ENV}"
- name: Download artifacts (if any)
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
if: ${{ inputs.download-artifact != '' }}
with:
name: ${{ inputs.download-artifact }}
Expand Down Expand Up @@ -193,7 +193,7 @@ jobs:
# NB: Keep this for compatibility with existing jobs and also keep in mind that only
# our AWS runners have access to S3
- name: Upload artifacts to GitHub (if any)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ always() && inputs.upload-artifact != '' && !inputs.upload-artifact-to-s3 }}
with:
name: ${{ inputs.upload-artifact }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update_disabled_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
user_name: "Pytorch Test Infra"
commit_message: "Updating unstable jobs"

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: disabled-artifacts
if-no-files-found: error
Expand All @@ -103,7 +103,7 @@ jobs:
needs: update-disabled-tests
steps:
- name: Download disabled artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: disabled-artifacts

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/windows_job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
submodules: ${{ inputs.submodules }}

- name: Download artifacts (if any)
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
if: ${{ inputs.download-artifact != '' }}
with:
name: ${{ inputs.download-artifact }}
Expand Down Expand Up @@ -195,7 +195,7 @@ jobs:
# NB: Keep this for compatibility with existing jobs and also keep in mind that only
# our AWS runners have access to S3
- name: Upload artifacts to GitHub (if any)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ always() && inputs.upload-artifact != '' && !inputs.upload-artifact-to-s3 }}
with:
name: ${{ inputs.upload-artifact }}
Expand Down

0 comments on commit 2ec4ddc

Please sign in to comment.