Skip to content

Commit

Permalink
Update
Browse files Browse the repository at this point in the history
[ghstack-poisoned]
  • Loading branch information
clee2000 committed Jan 3, 2025
1 parent da40b6b commit 30c51c0
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
echo ::group::setup Python environment
python -m venv .venv/
source .venv/bin/activate
pip install pip==23.0.1 pytest==7.2.0 rockset==1.0.3 jsonschema==4.17.3 clickhouse-connect==0.7.16
pip install pip==23.0.1 pytest==7.2.0 jsonschema==4.17.3 clickhouse-connect==0.7.16
echo ::endgroup::
# Test tools
Expand All @@ -51,7 +51,7 @@ jobs:
echo ::group::setup Python environment
python -m venv .venv/
source .venv/bin/activate
pip install pip==23.0.1 pytest==7.2.0 rockset==1.0.3 \
pip install pip==23.0.1 pytest==7.2.0 \
jsonschema==4.17.3 numpy==1.24.1 pandas==2.1.4 boto3==1.19.12 \
clickhouse-connect==0.7.16
echo ::endgroup::
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/update-test-times.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ jobs:
run: |
python -m torchci.update_test_times
env:
ROCKSET_API_KEY: ${{ secrets.ROCKSET_API_KEY }}
CLICKHOUSE_ENDPOINT: ${{ secrets.CLICKHOUSE_HUD_USER_URL }}
CLICKHOUSE_USERNAME: ${{ secrets.CLICKHOUSE_HUD_USER_USERNAME }}
CLICKHOUSE_PASSWORD: ${{ secrets.CLICKHOUSE_HUD_USER_PASSWORD }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/update_test_file_ratings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Install Dependencies
run: |
pip3 install --upgrade pip
pip3 install boto3==1.19.12 rockset==1.0.3 clickhouse-connect==0.7.16
pip3 install boto3==1.19.12 clickhouse-connect==0.7.16
cd test-infra/tools/torchci
pip3 install -e .
Expand Down Expand Up @@ -59,7 +59,6 @@ jobs:
# python3 test-infra/tools/torchci/td/td_heuristic_profiling.py
env:
ROCKSET_API_KEY: ${{ secrets.ROCKSET_API_KEY }}
CLICKHOUSE_ENDPOINT: ${{ secrets.CLICKHOUSE_HUD_USER_URL }}
CLICKHOUSE_USERNAME: ${{ secrets.CLICKHOUSE_HUD_USER_USERNAME }}
CLICKHOUSE_PASSWORD: ${{ secrets.CLICKHOUSE_HUD_USER_PASSWORD }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ if (-Not (Test-Path -Path $condaHook -PathType Leaf)) {
conda activate base

# Some dependencies are installed by pip before testing, pin all of them
pip install "ninja==1.10.0.post1" "future==0.18.2" "hypothesis==5.35.1" "expecttest==0.1.3" "librosa>=0.6.2" "scipy==1.6.3" "psutil==5.9.1" "pynvml==11.4.1" "pillow==9.2.0" "unittest-xml-reporting<=3.2.0,>=2.0.0" "pytest==7.1.3" "pytest-xdist==2.5.0" "pytest-flakefinder==1.1.0" "pytest-rerunfailures==10.2" "pytest-shard==0.1.2" "sympy==1.11.1" "xdoctest==1.0.2" "pygments==2.12.0" "opt-einsum>=3.3" "networkx==2.8.8" "mpmath==1.2.1" "pytest-rerunfailures==10.2" "pytest-cpp==2.3.0" "rockset==1.0.3"
pip install "ninja==1.10.0.post1" "future==0.18.2" "hypothesis==5.35.1" "expecttest==0.1.3" "librosa>=0.6.2" "scipy==1.6.3" "psutil==5.9.1" "pynvml==11.4.1" "pillow==9.2.0" "unittest-xml-reporting<=3.2.0,>=2.0.0" "pytest==7.1.3" "pytest-xdist==2.5.0" "pytest-flakefinder==1.1.0" "pytest-rerunfailures==10.2" "pytest-shard==0.1.2" "sympy==1.11.1" "xdoctest==1.0.2" "pygments==2.12.0" "opt-einsum>=3.3" "networkx==2.8.8" "mpmath==1.2.1" "pytest-rerunfailures==10.2" "pytest-cpp==2.3.0"
2 changes: 0 additions & 2 deletions tools/torchci/queue_alert.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@

REPO_ROOT = Path(__file__).resolve().parent.parent.parent

PROD_VERSIONS_FILE = REPO_ROOT / "torchci" / "rockset" / "prodVersions.json"

QUEUE_ALERT_LABEL = "queue-alert"

MAX_HOURS = 4
Expand Down
8 changes: 4 additions & 4 deletions tools/torchci/tests/test_queue_alert.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@

class TestGitHubPR(TestCase):
def test_filter_long_queues(self):
rockset_results = [
db_results = [
{"count": 30, "avg_queue_s": 0, "machine_type": "linux.gcp.a100.large"},
{"count": 100, "avg_queue_s": 0, "machine_type": "machine1"},
{"count": 30, "avg_queue_s": 3600 * 5, "machine_type": "machine2"},
]
long_queues = filter_long_queues(rockset_results)
long_queues = filter_long_queues(db_results)
self.assertEqual(len(long_queues), 3)

rockset_results = [
db_results = [
{
"count": 0,
"avg_queue_s": 3600 * 30,
Expand All @@ -22,7 +22,7 @@ def test_filter_long_queues(self):
{"count": 10, "avg_queue_s": 0, "machine_type": "machine1"},
{"count": 10, "avg_queue_s": 3600 * 1, "machine_type": "machine2"},
]
long_queues = filter_long_queues(rockset_results)
long_queues = filter_long_queues(db_results)
self.assertEqual(len(long_queues), 1)
self.assertEqual(long_queues[0].machine, "linux.gcp.a100.large")

Expand Down

0 comments on commit 30c51c0

Please sign in to comment.