[disablebot] Fix workflow when run on PR #6096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
clee2000
force-pushed
the
csl/update_disabled_tests
branch
from
16bb3e0 to
9e78265
Compare
janeyx99
reviewed
Jan 15, 2025
| # PyTorch bot token is the most obvious choice. Outside of the | ||
| # environment, we do not have access to this token so fall back to the | ||
| # GITHUB_TOKEN. | ||
| GITHUB_TOKEN: ${{ github.ref == 'refs/heads/main' && secrets.GH_MERGEBOT_TOKEN || secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
wait lol what is the diff between GH_MERGEBOT_TOKEN and GH_PYTORCHBOT_TOKEN
There was a problem hiding this comment.
I assume one is from pytorchmergebot and the other from pytorchbot but I don't actually know
I renamed here to GITHUB_TOKEN because I thought most people have a personal token saved as GITHUB_TOKEN and no mergebot token so when running locally they wouldn't have to remap. Also I guess the name would be misleading when the workflow is just using github token
malfet
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have access to the environment at PR time, so we don't have the GH_PYTORCHBOT_TOKEN. Instead we can fallback to GITHUB_TOKEN, but this doesn't have the necessary permissions for getting the correct unstable + disable jobs. However, being able to test the overall workflow on PR and the disable tests generator is better than nothing