Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ez][HUD] Remove rockset from benchmarks branch picker component #6129

Closed
wants to merge 2 commits into from
Closed

[ez][HUD] Remove rockset from benchmarks branch picker component #6129

wants to merge 2 commits into from

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jan 3, 2025

No description provided.

@clee2000 clee2000 marked this pull request as ready for review January 3, 2025 18:21
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jan 3, 2025 6:22pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025
@clee2000 clee2000 requested a review from a team January 3, 2025 18:21
huydhn
huydhn approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clee2000
Copy link
Contributor Author

clee2000 commented Jan 3, 2025

Closing in favor of #6133

@clee2000 clee2000 closed this Jan 3, 2025
@clee2000
Copy link
Contributor Author

clee2000 commented Jan 3, 2025

Wrong one, its #6131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clee2000 @huydhn @facebook-github-bot