Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Migrate seemethere/download-artifact-s3 locally #6157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwagantall
Copy link
Contributor

Hosting the code for seemethere/download-artifact-s3 locally to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Copy link

vercel bot commented Jan 10, 2025

@jwagantall is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2025
@malfet
Copy link
Contributor

malfet commented Jan 13, 2025

Changes looks good to me in principle, but we should put some automation into building the actions and testing them, if they are part of test-infra on a personal repo

Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this looks pretty reasonable but it needs some fixes to pass CI

@jwagantall
Copy link
Contributor Author

Thank you so much for the review! Working on fixing the CI issues and linting issues.

@jwagantall jwagantall force-pushed the migrate-download branch 3 times, most recently from 507a669 to 6cd95dd Compare January 21, 2025 20:07
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants