[CI] Enable TABS formatter/linter #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Seeing your changes here and pytorch/pytorch#144589, I remember that there is https://github.com/justinchuby/lintrunner-adapters which suppose to include all PT lint adapters there, so that we can just pip install to get the adapter, i.e. https://github.com/pytorch/executorch/blob/main/requirements-lintrunner.txt#L3. I think we might want to do the same for test-infra eventually. That repo looks a bit outdated though |
clee2000
force-pushed
the
csl/lint_tabs
branch
from
0d381fa to
e276e9e
Compare
clee2000
force-pushed
the
csl/lint_tabs
branch
from
e276e9e to
57d7f60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy over grep_linter from https://togithub.com/pytorch/pytorch/pull/144589.
Enable TABS linter in CI
Add paths to ignore list that don't currently work
Run formatter on clickhouse_queries folder