Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Enable SPACES formatter/linter #6161

Merged
merged 2 commits into from
Jan 13, 2025
Merged

[CI] Enable SPACES formatter/linter #6161

merged 2 commits into from
Jan 13, 2025

Conversation

clee2000
Copy link
Contributor

Enables the linter that checks for trailing spaces

Add one file that probably shouldn't be linted

Apply changes via lintrunner -a --take SPACES --all-files

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 11:28pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2025
@clee2000 clee2000 changed the title [CI] Enable SPACES linter [CI] Enable SPACES formatter/linter Jan 10, 2025
@clee2000 clee2000 marked this pull request as ready for review January 10, 2025 23:15
@clee2000 clee2000 requested a review from a team January 10, 2025 23:15
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, there are more run away spaces that I expect

@clee2000 clee2000 merged commit 80fbd83 into main Jan 13, 2025
110 of 115 checks passed
@clee2000 clee2000 deleted the csl/lint_spaces branch January 13, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants