Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pyfmt on .github and tools #6165

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Run pyfmt on .github and tools #6165

merged 1 commit into from
Jan 15, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jan 13, 2025

run lintrunner -a --all-files --take PYFMT

Update pyproject.toml with a few options for usort that make it more similar to pytorch

I can break this down into smaller PRs if this is too large

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 11:15pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 13, 2025
@clee2000 clee2000 marked this pull request as ready for review January 13, 2025 23:15
@clee2000 clee2000 requested a review from a team January 14, 2025 17:10
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too big to review but PR failures look unrelated, so yolo :D

@huydhn
Copy link
Contributor

huydhn commented Jan 14, 2025

There is a failure from this workflow https://github.com/pytorch/test-infra/actions/workflows/stronghold.yml, I have no idea what it is, but given its name, maybe we should clean it up

@clee2000 clee2000 merged commit a74b323 into main Jan 15, 2025
86 of 89 checks passed
@clee2000 clee2000 deleted the csl/lint_pyfmt branch January 15, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants