process_group: register via public API #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This registers the ProcessGroups via the public APIs (
Backend.register_backend
anddist.new_group
) rather than modifying internal state.This makes things a bit messier but fits better into the usual PyTorch init logic. This requires a global PG to be initialized. A future PR could detect if a PG is initialized and register this as the global PG if necessary.
Weirdly -- with how this works it ends up returning the exact same ProcessGroup object from
dist.new_group
. I'm not quite sure how that actually works. The Backend wrapper seems to unwrap itself when casted to PG.Test plan: