Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove linalg #190

Merged
merged 2 commits into from
Dec 13, 2024
Merged

remove linalg #190

merged 2 commits into from
Dec 13, 2024

Conversation

ryanhill1
Copy link
Member

@ryanhill1 ryanhill1 commented Dec 11, 2024 •
edited
Loading

Summary of changes

  • Removed qbraid_qir.qasm3.linag module in favor of pyqasm.linalg
  • Improved map_qasm_op_to_pyqir_callable implementation
  • Updated qasm3_to_qir docstring with external_gates arg

@ryanhill1 ryanhill1 marked this pull request as ready for review December 11, 2024 01:40
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
qbraid_qir/qasm3/maps.py 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@TheGupta2012 TheGupta2012 merged commit 8e0d51d into main Dec 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheGupta2012 TheGupta2012 Awaiting requested review from TheGupta2012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanhill1 @TheGupta2012