Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This close #2075, support streaming writer to set col style #2076

Merged
merged 2 commits into from
Jan 24, 2025
Merged

This close #2075, support streaming writer to set col style #2076

merged 2 commits into from
Jan 24, 2025

Conversation

mengpromax
Copy link
Contributor

@mengpromax mengpromax commented Jan 23, 2025 •
edited
Loading

Change-Id: I46c227cc449e2c95ce1921b668da0bc780d24853

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This close qax-os#2075, support streaming writer to set col style
c42fc95 
Change-Id: I46c227cc449e2c95ce1921b668da0bc780d24853
Signed-off-by: mengzhongyuan <[email protected]>
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 23, 2025
xuri
xuri requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I've left some comments. Unit test required for this PR.

stream.go Outdated Show resolved Hide resolved
stream.go Outdated Show resolved Hide resolved
@mengpromax
Copy link
Contributor Author

mengpromax commented Jan 24, 2025 via email

@xuri
This close qax-os#2075, introduce new function SetColStyle for stream…
2f858ce 
…ing writer to support set columns style

- Add new exported error variable ErrStreamSetColStyle
- Fix cell default style doesn't override by none-zero row style when set row by stream writer
- Update unit tests
@xuri xuri linked an issue Jan 24, 2025 that may be closed by this pull request
streaming writer support set col style #2075
Closed
1 task
@xuri xuri added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (7e614c5) to head (2f858ce).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2076   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          32       32           
  Lines       30023    30057   +34     
=======================================
+ Hits        29785    29819   +34     
  Misses        158      158           
  Partials       80       80
Flag Coverage Δ
unittests 99.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuri xuri merged commit 0e0e2da into qax-os:master Jan 24, 2025
29 checks passed
@mengpromax
Copy link
Contributor Author

@xuri Thanks for your patient review in github, this is my first pr. happy spring festival 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuri xuri xuri approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Excelize v2.9.1
Status: Features
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

streaming writer support set col style
2 participants
@mengpromax @xuri