Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use deprecated file mode U anymore #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

don't use deprecated file mode U anymore #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e23fced
don't use deprecated file mode U anymore
sjanssen2 Mar 5, 2024
8e6e180
avoid explicit type != type comparison: flake8
sjanssen2 Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qiita_client/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def __call__(self, server_url, job_id, output_dir):
logger.debug('Entered BaseQiitaPlugin.__call__()')
# Set up the Qiita Client
config = ConfigParser()
with open(self.conf_fp, 'U') as conf_file:
with open(self.conf_fp, 'r') as conf_file:
config.readfp(conf_file)

qclient = QiitaClient(server_url, config.get('oauth2', 'CLIENT_ID'),
Expand Down
2 changes: 1 addition & 1 deletion qiita_client/qiita_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def __init__(self, output_name, artifact_type, files, archive=None):

def __eq__(self, other):
logger.debug('Entered ArtifactInfo.__eq__()')
if type(self) != type(other):
if not isinstance(other, ArtifactInfo):
return False
if self.output_name != other.output_name or \
self.artifact_type != other.artifact_type or \
Expand Down
Loading