Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_job_status() now has option to ignore runtime errors #51

Merged
merged 20 commits into from
Jul 23, 2024

Conversation

charles-cowart
Copy link
Contributor

No description provided.

Migrating CI off Python 2.x to support latest change.
Since latest change is straightforward, current operation using Python
2.7 should not be disrupted.
Added script to add the root-ca used to sign Qiita's server.crt to
qiita_client's environment. The functionality in this small script may
be more useful if it becomes part of qiita_client itself.
Update PluginTestCase base class to rely on standard environment to
verify server credentials. Rely on new script to update standard
environment.
@charles-cowart
Copy link
Contributor Author

@antgonza ready for review! What do you think about adding the functionality of rootca_insert.py into the package itself?

@charles-cowart charles-cowart requested a review from antgonza July 18, 2024 01:40
Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments/questions.

.github/workflows/qiita-ci.yml Show resolved Hide resolved
.github/workflows/qiita-ci.yml Outdated Show resolved Hide resolved
.github/workflows/qiita-ci.yml Outdated Show resolved Hide resolved
.github/workflows/qiita-ci.yml Outdated Show resolved Hide resolved
qiita_client/qiita_client.py Show resolved Hide resolved
rootca_insert.py Outdated Show resolved Hide resolved
@charles-cowart
Copy link
Contributor Author

@antgonza ready for review!

@charles-cowart charles-cowart mentioned this pull request Jul 22, 2024
Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just a few questions.

qiita_client/qiita_client.py Outdated Show resolved Hide resolved
.github/workflows/qiita-ci.yml Outdated Show resolved Hide resolved
.github/workflows/qiita-ci.yml Outdated Show resolved Hide resolved
.github/workflows/qiita-ci.yml Outdated Show resolved Hide resolved
@charles-cowart
Copy link
Contributor Author

@antgonza ready for review!

@antgonza antgonza merged commit 21069c3 into qiita-spots:master Jul 23, 2024
2 checks passed
@antgonza
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants