-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes issue encountered during testing. #96
fixes issue encountered during testing. #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question.
qp_klp/Protocol.py
Outdated
with open(files_to_count_path, 'w') as f: | ||
# for raw_counts_r1r2, count corrected.err_barcode_removed files | ||
# (TellReadJob final output). | ||
for root, dirs, files in walk(self.raw_fastq_files_path): | ||
for _file in files: | ||
if 'corrected.err_barcode_removed' in _file: | ||
print(join(root, _file), file=f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand this step, it's just used for printing and not nothing gets written in the file, is that what you want to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is equivalent to writing f.write("%s\n" % join(root, _file)). There is an additional parameter "file=f" that redirects the print statement from stdout to the file handle 'f'. I've been using this form lately instead of constructing a string just for the sake of appending a newline.
qp_klp/Protocol.py
Outdated
# (TellReadJob final output). | ||
for root, dirs, files in walk(self.raw_fastq_files_path): | ||
for _file in files: | ||
if 'corrected.err_barcode_removed' in _file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these files being examined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I have this marked in my notes. there is a patch for this that expects the integrated results directory instead of Full.
No description provided.