Skip to content

Commit

Permalink
QOLOE-441 Removing redundant aria-labelledby from navigation bar
Browse files Browse the repository at this point in the history
  • Loading branch information
ghazal-salehi committed Jul 29, 2024
1 parent 37c0cbd commit c24f931
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/components/bs5/header/header.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
{{/if}}
</a>
{{#if dropdown_enabled}}
<ul class="dropdown-menu dark" aria-labelledby="dropdown{{id}}" role="list">
<ul class="dropdown-menu dark" role="list">
{{#isType dropdown_options.dropdown_type "list"}}
{{#if dropdown_options.dropdown_config}}
{{#each dropdown_options.dropdown_config.groups}}
Expand Down
6 changes: 3 additions & 3 deletions src/components/bs5/navbar/navbar.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</svg>
</a>
{{#if navigation_items}}
<ul id="dropdown-menu" class="dropdown-menu" aria-labelledby="menuDropdown" role="menu"
<ul id="dropdown-menu" class="dropdown-menu" role="menu"
data-bs-popper="none">
<div class="row dropdown-menu__inner">
{{#if dropdown_options}}
Expand Down Expand Up @@ -109,7 +109,7 @@
</button>

{{#if navigation_items}}
<ul id="dropdown-menu" class="dropdown-menu" aria-labelledby="menuDropdown" role="menu"
<ul id="dropdown-menu" class="dropdown-menu" role="menu"
data-bs-popper="none">
<div class="row dropdown-menu__inner">
{{#if dropdown_options}}
Expand Down Expand Up @@ -187,7 +187,7 @@
</button>

{{#if dropdown_enabled}}
<ul id="dropdown-menu-{{id}}" class="dropdown-menu" aria-labelledby="menuDropdown-{{id}}"
<ul id="dropdown-menu-{{id}}" class="dropdown-menu"
role="menu" data-bs-popper="none">
<div class="row dropdown-menu__inner">
{{#if dropdown_options.dropdown_config.groups}}
Expand Down

0 comments on commit c24f931

Please sign in to comment.