Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qoloe 222 formio thankyou page #300

Merged
merged 12 commits into from
Jun 24, 2024
Merged

Conversation

SenChung
Copy link
Contributor

The Footer FormIO Thank you page is working - Thanks to William
The Thank you page styles has been updated.
Note: The hiding of the "Leave your feedback" is done using CSS:has and the use of display:hidden & visibility:none for accessibility reasons.

@SenChung SenChung added the bug Something isn't working label Jun 24, 2024
@SenChung SenChung requested review from stvp-qld and epinder-qld June 24, 2024 04:34
@epinder-qld
Copy link

epinder-qld commented Jun 24, 2024

@SenChung can you increase the margin underneath each paragraph to 20px/1.25rem (currently it is 16px/1rem).
(Including the paragraph under the submit feedback button)

epinder-qld
epinder-qld previously approved these changes Jun 24, 2024
@SenChung
Copy link
Contributor Author

@Epinder-SSQ
Updated the paragraph margins and redid a class name due to formIO structure changes.
Everything should now by good.

@SenChung SenChung requested a review from epinder-qld June 24, 2024 06:20
epinder-qld
epinder-qld previously approved these changes Jun 24, 2024
Copy link

@epinder-qld epinder-qld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you page reviewed and crossed checked.

@SenChung
Copy link
Contributor Author

There was a merging issue within the CSS.
This is now fixed and needs to be reviewed.

@SenChung SenChung requested a review from epinder-qld June 24, 2024 23:18
@SenChung SenChung merged commit af7b370 into develop Jun 24, 2024
6 of 7 checks passed
@SenChung SenChung deleted the QOLOE-222-formio-thankyou-page branch June 25, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants