Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract constants for runtime and builder images #42652

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Aug 20, 2024

This avoids having to modify multiple places when there is an update.
I decided to put the constants in core-deployment to avoid the runtime overhead (it's a lot of strings). We may revisit later.

Fix #42389

@cescoffier cescoffier requested a review from gsmet August 20, 2024 13:30
@cescoffier cescoffier added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Aug 20, 2024
@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform area/testing labels Aug 20, 2024

This comment has been minimized.

Copy link

github-actions bot commented Aug 20, 2024

🎊 PR Preview c75c0f4 has been successfully built and deployed to https://quarkus-pr-main-42652-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. I added some comments/concerns though.

Also wondering if we should adjust:

  • extensions/container-image/container-image-docker-common/deployment/src/test/java/io/quarkus/container/image/docker/common/deployment/RedHatOpenJDKRuntimeBaseProviderTest.java
  • extensions/container-image/container-image-docker-common/deployment/src/test/java/io/quarkus/container/image/docker/common/deployment/UbiMinimalBaseProviderTest.java

(I had a look at https://github.com/quarkusio/quarkus/pull/42097/files)

@cescoffier
Copy link
Member Author

@gsmet Any opinion about the reference located in the javadoc?

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 21, 2024

@cescoffier could you clarify your question?

If it's about the convention you put in the Javadoc, looks good.
If it's about the image references in the Javadoc, I don't think we can fix that automatically unfortunately :/

This avoids having to modify multiple places when there is an update.
I decided to put the constants in core-deployment to avoid the runtime overhead (it's a lot of strings). We may revisit later.
@cescoffier cescoffier force-pushed the docker-image-constants branch from c8379e4 to 6beef7a Compare August 21, 2024 14:22
@cescoffier
Copy link
Member Author

I fixed the 2 locations you mentioned.

Copy link

quarkus-bot bot commented Aug 21, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 6beef7a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Aug 21, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6beef7a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.VertxTcpMetricsNoClientMetricsTest.testTcpMetricsWithoutClientMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:931)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:350)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:343)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:833)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:824)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:814)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

⚙️ JVM Tests - JDK 21

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess - History

  • Expecting actual not to be null - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual not to be null
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$FieldAccessEnhancedDelegate$1.assertValue(PublicFieldAccessInheritanceTest.java:132)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.doTestFieldAccess(PublicFieldAccessInheritanceTest.java:91)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess(PublicFieldAccessInheritanceTest.java:52)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:499)

@gsmet gsmet merged commit 77654a9 into quarkusio:main Aug 22, 2024
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 22, 2024
@cescoffier cescoffier deleted the docker-image-constants branch August 26, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/platform Issues related to definition and interaction with Quarkus Platform area/testing triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralize reference to UBI images (and maybe others)
2 participants