Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): set viewport meta to satisfy WCAG AA (fix: #17031) #17728

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SamVanini
Copy link

@SamVanini SamVanini commented Dec 30, 2024

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Fix issue related WCAG 2.1 AA guideline 1.4.4

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

The following PR introduce a change to the viewport meta in all the templates used to create the structure of a new Quasar project, according to WCAG 2.1 guidelines.

In particular, guideline 1.4.4 states the following:

Except for captions and images of text, text can be resized without assistive technology up to 200 percent without loss of content or functionality.

I set the values of user_scalable and maximum_scale accordingly to Viewport MDN guide

Thanks to these changes now the accessibility test related to this feature will pass

Fixes #17031

@yusufkandemir
Copy link
Member

I believe they were set that way to avoid problems with scaling. Unfortunately, not everything has been set up to be scalable. See quasarframework/rfcs#3

up to 200 percent without loss of content or functionality.

If it doesn't satisfy this part, then it will just pass an automated check, but it won't satisfy user testing. So, we need to test it and verify it works fine first. If it doesn't, then the stuff mentioned in the RFC needs to be addressed first, which will take a lot of work. But it would be fantastic if you would be willing to contribute the relevant parts if needed.

@yusufkandemir yusufkandemir changed the title fix: #17031 set viewport meta values according to WCAG AA rules fix(ui): set viewport meta to satisfy WCAG AA (fix: #17031) Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta viewport tag is not accessible
2 participants