Add editor funcionality #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll try to review this over the weekend. |
quietvoid
requested changes
Jan 11, 2025
quietvoid
reviewed
Jan 11, 2025
That way the same edits file for the DoVi layer could be used to modify the HDR10+ layer
Reverting metadata_json.rs it to previous version
|
It seems fine. Just need to run |
|
Done |
quietvoid
approved these changes
Jan 15, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement a simple editor functionality capable of removing frame, duplicating them and setting scene changes, most of the syntax was inherited from dovi_tool's editor
First time writing rust code, I know that the code is more C(arbon) then Iron Oxide, most of that was written copying code from other part of the codebase and dovi_tool.
I've made some tests and seems to work as expected, at least as far as I'm able to check due to size of the json files