Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spaces around dollar operator #1246

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

closes #1245

library(styler)

styler::cache_deactivate()
#> Deactivated cache.
style_text("mtcars $disp")
#> mtcars$disp
style_text("mtcars$ disp")
#> mtcars$disp
style_text("mtcars $ disp")
#> mtcars$disp

Created on 2024-12-07 with reprex v2.1.1

Copy link
Contributor

github-actions bot commented Dec 7, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if bf5c500 is merged into main:

  • ✔️cache_applying: 157ms -> 156ms [-4.94%, +3.71%]
  • ✔️cache_recording: 561ms -> 563ms [-0.76%, +1.4%]
  • ✔️without_cache: 1s -> 1s [-0.39%, +0.53%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could not have done it better.

@IndrajeetPatil IndrajeetPatil merged commit c637dc0 into main Dec 8, 2024
18 checks passed
@IndrajeetPatil IndrajeetPatil deleted the rm-space-around-dollar branch December 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styler does not remove space after $
2 participants