chore: turn Mapping
into a wrapper type
#33
+112
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tackles the 1st:
since
Mapping
is now a wrapper type, i had to splitStorageStorable
into 2 types of traits: based on whether there is direct interaction with the db or nor.then, i created 2 traits (
DirectStorage
,KeyValueStorage
) to signal the publicfn read()
,fn write()
API that devs will use. Maybe skill issue, but i didn't mange to do it with a single trait. Open to feedback or a better design if this one feels too convoluted.I tried to summarize my logic in the docs: