Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build, ci): Bring Python in CI #424

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix(build, ci): Bring Python in CI #424

merged 2 commits into from
Jan 15, 2025

Conversation

rabbitstack
Copy link
Owner

What is the purpose of this PR / why it is needed?

Python 3.7 was removed from the Windows Server 2022 image, so we must set it up manually. Also, fail if the compilation doesn't succeed to make CI red.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


@rabbitstack rabbitstack added the ci Anything CI (Continuous Integration) related label Jan 15, 2025
@rabbitstack rabbitstack force-pushed the bring-python-in-ci branch 2 times, most recently from 617aa29 to f2fdc4d Compare January 15, 2025 18:00
Python 3.7.x was removed from the Windows Server 2022 image, so
we have to set it up manually.
@rabbitstack rabbitstack merged commit bc68f2b into master Jan 15, 2025
8 checks passed
@rabbitstack rabbitstack deleted the bring-python-in-ci branch January 15, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Anything CI (Continuous Integration) related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant