Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct class name on Alpha Tyrranax #504

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

DanceMore
Copy link
Contributor

when using inside Rails with RACK_ENV=production, a bunch of Zeitwerk autoloads happen and this one fails:

/usr/local/bundle/ruby/3.3.0/gems/zeitwerk-2.6.12/lib/zeitwerk/loader/callbacks.rb:33:in `on_file_autoloaded': expected file /usr/local/bundle/ruby/3.3.0/bundler/gems/mtg-581ba0a9dc3c/lib/magic/cards/alpha_tyrranax.rb to define constant Magic::Cards::AlphaTyrranax, but didn't (Zeitwerk::NameError)

      raise Zeitwerk::NameError.new(msg, cref.last)

https://gatherer.wizards.com/Pages/Card/Details.aspx?name=Alpha+Tyrranax

Ruby file used 2 n in the class name, Zeitwerk expects string matches between Class and File name. patch should resolve. (I didn't test yet, I just rm'd the offending file and my docker builds for my Rails app take 10 minutes)

@radar radar merged commit 5e2670d into radar:master Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants