Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #499 pkcli gets commands from class Commands #500

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Fix #499 pkcli gets commands from class Commands #500

merged 3 commits into from
Aug 23, 2024

Conversation

robnagler
Copy link
Member

  • Instantiate the class first
  • Ignore superclass methods

@robnagler
Fix #499 pkcli gets commands from class Commands
f1433fa 
- Instantiate the class first
- Ignore superclass methods
@robnagler robnagler requested a review from e-carlin August 23, 2024 14:06
e-carlin
e-carlin approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@e-carlin e-carlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits. A test might be nice for at least demoing how to use.

pykern/pkcli/__init__.py Outdated Show resolved Hide resolved
pykern/pkcli/__init__.py Outdated Show resolved Hide resolved
@robnagler robnagler merged commit 80278ba into master Aug 23, 2024
3 checks passed
@robnagler robnagler deleted the 499-pkcli-class branch August 23, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-carlin e-carlin e-carlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robnagler @e-carlin