Handler Stream Dispose Fix #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raftario
requested changes
Jun 21, 2023
Hydra/WrapperStream.cs
Outdated
|
|
||
| protected WrapperStream(Stream stream) | ||
| protected WrapperStream(Stream stream, bool ownStream = false) |
There was a problem hiding this comment.
I'd prefer if this was not a default parameter, since there's no real reason one should be the default over the other in which case the behaviour should probably always be specified by the caller.
Hydra/SizedStream.cs
Outdated
| @@ -20,7 +20,7 @@ internal class SizedStream : WrapperStream | |||
| /// </summary> | |||
| /// <param name="stream">Stream to wrap</param> | |||
| /// <param name="length">Length to limit to</param> | |||
| internal SizedStream(Stream stream, int length) : base(stream) | |||
| internal SizedStream(Stream stream, int length, bool ownStream = false) : base(stream, ownStream) | |||
|
Done. However the WebSocket changes are needed in this PR unless you're fine with compile errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously handlers for HTTP Requests such as BMBF's web server could dispose the NetworkStream used to communicate to the client when say using a ZipStream.
It seems undesirable to have handlers abruptly close the stream used to communicate to the client, even intentionally. Without this, any result error or otherwise would never reach the client and the server would spam exceptions.
This has already been fixed in BMBF 2 by leaving the ZipStream stream open in MR !13.
I applied similar changes to the web socket though those are more questionable and probably redundant.