Add AssertChannelSettledEvent #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the call-arguments for `participant1` and `participant2` are unordered and the order is not enforced based on who calls the function, both possibilities have to be checked when making assertions on ChannelSettled events that are coop-settle related. This commit introduces the `AssertChannelSettledEvent` task, that allows for more advanced assertions related to ChannelSettled events.
istankovic
reviewed
Aug 24, 2021
istankovic
reviewed
Aug 24, 2021
istankovic
suggested changes
Aug 24, 2021
Before the integer values for the event attributes to be matched weren't converted to int values, although the deserialized events contain integer values. This caused the filter matching to fail although the events were present onchain. Now the expected attributes are converted from strings to integers.
ezdac
force-pushed
the
feature/channel_settled_assert_task
branch
from
1a98fdb to
09fff46
Compare
ezdac
commented
Aug 25, 2021
istankovic
reviewed
Aug 25, 2021
istankovic
reviewed
Aug 25, 2021
istankovic
reviewed
Aug 25, 2021
istankovic
reviewed
Aug 25, 2021
istankovic
reviewed
Aug 25, 2021
|
A test would be nice. But I saw that there's none for |
ezdac
force-pushed
the
feature/channel_settled_assert_task
branch
from
40ae3c9 to
e3c88ab
Compare
Querying blockchain events as well as filtering events based on event_args had to be used in 2 tasks with differing strictness on assertions regarding the `num_events`. In order to separate validation of config arguments and internal usage of the underlying functionality, a Mixin was used.
ezdac
force-pushed
the
feature/channel_settled_assert_task
branch
from
03e9630 to
9f3184e
Compare
ezdac
force-pushed
the
feature/channel_settled_assert_task
branch
from
9f3184e to
6209f98
Compare
istankovic
approved these changes
Aug 26, 2021
The dependencies have not been updated for quite some time.
With the updated raiden version, the smoketest require a functioning PFS that returns the newly used metadata functionality. Right now a simple PFS dummy server is started, that doesn't have this functionality.
ezdac
force-pushed
the
feature/channel_settled_assert_task
branch
from
6209f98 to
89901e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the call-arguments for
participant1andparticipant2areunordered and the order is not enforced based on who calls the function,
both possibilities have to be checked when making assertions on
ChannelSettled events that are coop-settle related.
This commit introduces the
AssertChannelSettledEventtask,that allows for more advanced assertions related to ChannelSettled
events.
Addition: dependencies update
The pinned
raidenandmatrix-synapseversions as well as updates introduced by thepoetry lockcommand were also updated in this PR - this causes the smokiest to fail due lack of a functioning PFS in the environment (#688).The smoketest therefore was disabled in the CI.