Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Options added to 'on' helper #90

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[Feature] Options added to 'on' helper #90

merged 1 commit into from
Oct 9, 2024

Conversation

franpb14
Copy link
Contributor

@franpb14 franpb14 commented Oct 9, 2024 •
edited by markets
Loading

Changes

  • optional param options added to on helper
  • existing test adapted
  • new test to check that options are working

Closes #86

markets
markets approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@markets markets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice @franpb14 👏🏼 👏🏼 No worries about the CI errors, the tests are passing ✅, but it fails when trying to publish the coverage report.

@markets markets merged commit 32fcc47 into ralixjs:master Oct 9, 2024
1 check failed
@franpb14 franpb14 deleted the on-accepting-options branch October 10, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markets markets markets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding options in on helper
2 participants
@franpb14 @markets