Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NeuVector Helm values.yaml & questions.yaml to be more easily consumable and less error prone #2709

Closed
wants to merge 6 commits into from

Conversation

frank-at-suse
Copy link

Issue:

As well as numerous other community complaints (i.e. container runtime selection)

Problem

NeVector Helm chart is difficult to consume and causes issues with installation

Solution

This PR addresses several issues with consuming the NeuVector Helm chart - namely embedding YAML documents within YAML documents (not best practice)., exposing otherwise useful buried configuration options as top-level values, slipstreaming in to this chart the 'monitoring' chart, and presenting questions.yaml with a much more user-friendly format.

Engineering Testing

Manual Testing

Only issue encountered is that the prometheus-exporter image is not in the Rancher Prime repository, is the system default registry is pointing to Rancher Prime repo, or any repo built via a Rancher release's images.txt, the monitoring deployment will fail.

Backporting considerations

None

@frank-at-suse
Copy link
Author

Closing this one to do upstream chart first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant