Refactor NeuVector Helm values.yaml & questions.yaml to be more easily consumable and less error prone #2709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
As well as numerous other community complaints (i.e. container runtime selection)
Problem
NeVector Helm chart is difficult to consume and causes issues with installation
Solution
This PR addresses several issues with consuming the NeuVector Helm chart - namely embedding YAML documents within YAML documents (not best practice)., exposing otherwise useful buried configuration options as top-level values, slipstreaming in to this chart the 'monitoring' chart, and presenting questions.yaml with a much more user-friendly format.
Engineering Testing
Manual Testing
Only issue encountered is that the prometheus-exporter image is not in the Rancher Prime repository, is the system default registry is pointing to Rancher Prime repo, or any repo built via a Rancher release's images.txt, the monitoring deployment will fail.
Backporting considerations
None