vai: do not discard closing statement errors #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio Moioli <[email protected]>
9 tasks
tomleb
reviewed
Jan 24, 2025
| defer func() { | ||
| cerr := i.CloseStmt(stmt) | ||
| if cerr != nil { | ||
| err = errors.Join(err, cerr) |
There was a problem hiding this comment.
Does the error message from cerr provide enough context to know that it came from this close statement call (or just allow us to troubleshoot)?
There was a problem hiding this comment.
Hopefully, but that really depends on the SQLite library implementation.
I could add the statement as context if you prefer that way.
There was a problem hiding this comment.
if it's not too much trouble yes that'd be great to have a bit more context, just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors in deferred
CloseStmtcalls are currently ignored.This patch captures such errors and returns them (possibly joined with another error if it happened).
Part of #47825