Make schema type definitions recursive. #464
Draft
+65
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prachidamle
requested review from
ericpromislow and
tomleb
and removed request for
a team
pkg/schema/definitions/visitor.go
Outdated
| @@ -20,23 +20,34 @@ func (s *schemaFieldVisitor) VisitArray(array *proto.Array) { | |||
| // it was kept this way to provide backwards compat with previous endpoints. | |||
There was a problem hiding this comment.
There's something I don't understand about this PR:
- The PR title says to make schema type defs recursive
- The are no changes in the two functions that do anything recursive -- the only recursive bit is in the description field
- Each function has a comment saying : "this currently is not recursive and provides little information for nested types"
I don't understand the problem enough to see which part this PR is actually solving.
There was a problem hiding this comment.
Fair points. I think the word "recursive" may have been misused in the issue related to this PR and then I make it worse by using that word again. I think it's more about accurately reflecting nested definitions. Once I get something slightly stable, I plan to check with the UI team since they're probably the principal consumers of these schemas to see if what I've done is matching what they are expecting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #45501