Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cluster role cleanup #108

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Fix/cluster role cleanup #108

merged 2 commits into from
Feb 15, 2021

Conversation

rkage
Copy link
Member

@rkage rkage commented Feb 15, 2021

Description

Clean up some problems identified in #107

Checklist

  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • All commits contain a well written commit description including a title, description and a Fixes: #XXX line if the commit addresses a particular GitHub issue.
  • All workflow validation and compliance checks are passing.

Issue Ref (Optional)

Addresses some of the findings in #107

  • Remove legacy references to master and workers terminology replaced with controlplane and nodes respectively.
  • Move variables around in all.yml and cluster.yml, eliminated duplication and some confusion.

xunholy
xunholy approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work @rkage lets ship it!

@rkage rkage merged commit cfeec85 into main Feb 15, 2021
@rkage rkage deleted the fix/cluster-role-cleanup branch February 15, 2021 14:04
@rkage rkage restored the fix/cluster-role-cleanup branch February 15, 2021 14:04
@rkage rkage deleted the fix/cluster-role-cleanup branch February 15, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xunholy xunholy xunholy approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkage @xunholy