Update ray-operator/controllers/ray/common/pod.go

Co-authored-by: Rueian <[email protected]> Signed-off-by: Blocka <[email protected]>
ray-project · Jan 18, 2025 · 201a8d8 · 201a8d8
1 parent 5cadced
commit 201a8d8
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/ray-operator/controllers/ray/common/pod.go b/ray-operator/controllers/ray/common/pod.go
@@ -153,11 +153,9 @@ func configureGCSFaultTolerance(podTemplate *corev1.PodTemplateSpec, instance ra
 				// job can connect to Redis using the username.
 				if !utils.EnvVarExists(utils.REDIS_USERNAME, container.Env) {
 					// setting the REDIS_USERNAME env var from the params
-					redisUsernameEnv := corev1.EnvVar{Name: utils.REDIS_USERNAME}
 					if value, ok := instance.Spec.HeadGroupSpec.RayStartParams["redis-username"]; ok {
-						redisUsernameEnv.Value = value
+						container.Env = append(container.Env, corev1.EnvVar{Name: utils.REDIS_USERNAME, Value: value})
 					}
-					container.Env = append(container.Env, redisUsernameEnv)
 				}
 				// If users directly set the `redis-password` in `rayStartParams` instead of referring
 				// to a K8s secret, we need to set the `REDIS_PASSWORD` env var so that the Redis cleanup