[RayCluster][Feature] skip suspending worker groups if the in-tree au…

…toscaler is enabled to prevent ray cluster from malfunctioning

Signed-off-by: Rueian <[email protected]>

ray-operator/controllers/ray/raycluster_controller.go

@@ -267,7 +267,7 @@ func validateRayClusterSpec(instance *rayv1.RayCluster) error {
 		for _, workerGroup := range instance.Spec.WorkerGroupSpecs {
 			if workerGroup.Suspend != nil && *workerGroup.Suspend {
 				// TODO (rueian): This can be supported in future Ray. We should check the RayVersion once we know the version.
-				return fmt.Errorf("suspending worker groups is not supported with Autoscaler enabled")
+				return fmt.Errorf("suspending worker groups is not currently supported with Autoscaler enabled")
 			}
 		}
 	}

ray-operator/controllers/ray/raycluster_controller_test.go

@@ -878,7 +878,7 @@ var _ = Context("Inside the default namespace", func() {
 				time.Second*3, time.Millisecond*500).Should(BeNil(), "Should be able to see RayCluster: %v", rayCluster.Name)
 		})
 
-		It("Check the number of Pods and add finalizers", func() {
+		It("Check the number of Pods", func() {
 			Eventually(listResourceFunc(ctx, &allPods, allFilters...), time.Second*3, time.Millisecond*500).
 				Should(Equal(4), fmt.Sprintf("all pods %v", allPods.Items))
 		})
@@ -889,7 +889,7 @@ var _ = Context("Inside the default namespace", func() {
 			Expect(err).NotTo(HaveOccurred(), "Failed to update RayCluster")
 		})
 
-		It("Worker pods should be not deleted and head pod should still be running", func() {
+		It("Worker pods should not be deleted and head pod should still be running", func() {
 			Consistently(listResourceFunc(ctx, &allPods, workerFilters...), time.Second*5, time.Millisecond*500).
 				Should(Equal(3), fmt.Sprintf("all pods %v", allPods.Items))
 			Consistently(listResourceFunc(ctx, &allPods, headFilters...), time.Second*5, time.Millisecond*500).

ray-operator/controllers/ray/raycluster_controller_unit_test.go

@@ -3737,14 +3737,13 @@ func TestValidateRayClusterSpecSuspendingWorkerGroup(t *testing.T) {
 			},
 		},
 	}
-	workerGroupSpec := rayv1.WorkerGroupSpec{
+	workerGroupSpecSuspended := rayv1.WorkerGroupSpec{
 		Template: corev1.PodTemplateSpec{
 			Spec: corev1.PodSpec{
 				Containers: []corev1.Container{{Name: "ray-worker"}},
 			},
 		},
 	}
-	workerGroupSpecSuspended := *workerGroupSpec.DeepCopy()
 	workerGroupSpecSuspended.Suspend = ptr.To[bool](true)
 
 	tests := []struct {
@@ -3774,7 +3773,7 @@ func TestValidateRayClusterSpecSuspendingWorkerGroup(t *testing.T) {
 				},
 			},
 			expectError:  true,
-			errorMessage: "suspending worker groups is not supported with Autoscaler enabled",
+			errorMessage: "suspending worker groups is not currently supported with Autoscaler enabled",
 		},
 	}