[Refactor] Move functions that don’t rely on the controller to non-controller member functions #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
win5923
changed the title
MortalHappiness
approved these changes
Jan 15, 2025
win5923
force-pushed
the
refactor/issue#2741
branch
2 times, most recently
from
c1d53aa to
1e35292
Compare
…ntroller member functions Signed-off-by: win5923 <[email protected]>
win5923
force-pushed
the
refactor/issue#2741
branch
from
1e35292 to
6d18f7b
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#2741
Related issue number
Closes #2741
Checks