[kubectl-plugin] Change error msg for ray job submit when waiting for cluster #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Jan 17, 2025
| @@ -326,7 +326,7 @@ func (options *SubmitJobOptions) Run(ctx context.Context, factory cmdutil.Factor | |||
| } | |||
| clusterReady = isRayClusterReady(currCluster) | |||
| if !clusterReady { | |||
| err = fmt.Errorf("Cluster is not ready: %w", err) | |||
| err = fmt.Errorf("Cluster is not ready") | |||
There was a problem hiding this comment.
Do we even need an error?
fmt.Println("Cluster is not ready yet...")
There was a problem hiding this comment.
I think it gives visibility to what stage of the command is currently at. WDYT?
There was a problem hiding this comment.
by passing an error to fmt.Println instead of just inlining the string?
chiayi
force-pushed
the
kubectl-plugin-quickfix
branch
from
c03b2a6 to
3bbe8d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Error msg doesn't have an error to print out, printing out "Cluster is not ready" is enough.
Related issue number
Checks