refactor: removed fatal logs from GetTxnOpts() #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yashk767 there re conflicts |
Yashk767
force-pushed
the
yash/raz-1103-remove-fatal-logs-from-voting-process
branch
from
3e3754c to
833b5e7
Compare
ashish10677
approved these changes
Dec 13, 2024
rajkharvar
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a additional return type
errortoGetTxnOpts()which would return error in any of the error case instead of existing fatal.Fixes https://linear.app/interstellar-research/issue/RAZ-1103
How Has This Been Tested?