fix: clear button should have type="button" (#83)

react-component · Nov 30, 2024 · 999c41a · 999c41a
1 parent 8e721a0
commit 999c41a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/BaseInput.tsx b/src/BaseInput.tsx
@@ -81,6 +81,7 @@ const BaseInput = React.forwardRef<HolderRef, BaseInputProps>((props, ref) => {
 
       clearIcon = (
         <button
+          type="button"
           onClick={(event) => {
             handleReset?.(event);
             onClear?.();

diff --git a/tests/__snapshots__/index.test.tsx.snap b/tests/__snapshots__/index.test.tsx.snap
@@ -117,6 +117,7 @@ exports[`Input allowClear should change type when click 1`] = `
     >
       <button
         class="rc-input-clear-icon"
+        type="button"
       >
         ✖
       </button>
@@ -140,6 +141,7 @@ exports[`Input allowClear should change type when click 2`] = `
     >
       <button
         class="rc-input-clear-icon rc-input-clear-icon-hidden"
+        type="button"
       >
         ✖
       </button>
@@ -163,6 +165,7 @@ exports[`Input allowClear should not show icon if defaultValue is undefined or e
     >
       <button
         class="rc-input-clear-icon rc-input-clear-icon-hidden"
+        type="button"
       >
         ✖
       </button>
@@ -186,6 +189,7 @@ exports[`Input allowClear should not show icon if defaultValue is undefined or e
     >
       <button
         class="rc-input-clear-icon rc-input-clear-icon-hidden"
+        type="button"
       >
         ✖
       </button>
@@ -209,6 +213,7 @@ exports[`Input allowClear should not show icon if value is undefined or empty st
     >
       <button
         class="rc-input-clear-icon rc-input-clear-icon-hidden"
+        type="button"
       >
         ✖
       </button>
@@ -232,6 +237,7 @@ exports[`Input allowClear should not show icon if value is undefined or empty st
     >
       <button
         class="rc-input-clear-icon rc-input-clear-icon-hidden"
+        type="button"
       >
         ✖
       </button>