Validation script enhancements #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
whindsaks
commented
Oct 24, 2023
whindsaks
commented
- Python 3.4 compatible so that validate-rapps.py can be executed on ROS.
- Validate the license type field.
- Print a harmless warning if License is set to the useless value of "Unknown"
|
A pity that you bundled the license thing with that 2nd aspect of improving the compat to older Python. |
JoachimHenze
approved these changes
Oct 24, 2023
learn-more
reviewed
Oct 25, 2023
|
|
||
| if arch: | ||
| if arch not in ALL_ARCH: | ||
| reporter.add(self, self._text.index(arch) + 1, f'Unknown architecture: "{arch}"') | ||
| reporter.add(self, self._text.index(arch) + 1, 'Unknown architecture: "%s"' % arch) |
There was a problem hiding this comment.
Why are you using a different format method here?
There was a problem hiding this comment.
Because the syntax is shorter and there is no ambiguity about which argument goes where.
learn-more
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.