Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find existing saga data when the assembly version changes #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Could not find existing saga data when the assembly version changes #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Rebus.PostgreSql/PostgreSql/Sagas/PostgreSqlSagaStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.Linq;
// ReSharper disable once RedundantUsingDirective (because .NET Core)
using System.Reflection;
using System.Text.RegularExpressions;
using System.Threading.Tasks;
using Npgsql;
using NpgsqlTypes;
Expand Down Expand Up @@ -413,7 +414,15 @@ async Task CreateIndex(ISagaData sagaData, PostgresConnection connection, IEnume

string GetSagaTypeName(Type sagaDataType)
{
return sagaDataType.FullName;
return _removeVersionFromTypeFullName();

// Rebus cannot find existing saga when the version changes, which breaks a long-running saga with deployments during the saga lifetime.
string _removeVersionFromTypeFullName()
{
return sagaDataType.FullName != null
? Regex.Replace(sagaDataType.FullName, @"Version=\d+\.\d+\.\d+\.\d+, ", "")
: null;
}
}

static List<KeyValuePair<string, string>> GetPropertiesToIndex(ISagaData sagaData, IEnumerable<ISagaCorrelationProperty> correlationProperties)
Expand Down